Get rid of statement expressions from all core code for MSVC windows #6503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6503
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 68714ad with merge base 41a57e6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64953673 |
larryliu0820
approved these changes
Oct 25, 2024
tarun292
added a commit
that referenced
this pull request
Oct 25, 2024
…6503) Summary: Statement expressions are supported in GCC but not in MSVC, so re-writing the macros in core that use statement expressions into expressions that use `do{}while(0)`. Reviewed By: larryliu0820 Differential Revision: D64953673
tarun292
force-pushed
the
export-D64953673
branch
from
51bc2ac to
748df0e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64953673 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
…6503) Summary: Statement expressions are supported in GCC but not in MSVC, so re-writing the macros in core that use statement expressions into expressions that use `do{}while(0)`. Reviewed By: larryliu0820 Differential Revision: D64953673
facebook-github-bot
force-pushed
the
export-D64953673
branch
from
748df0e to
0b708f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64953673 |
tarun292
added a commit
that referenced
this pull request
Oct 29, 2024
…6503) Summary: Statement expressions are supported in GCC but not in MSVC, so re-writing the macros in core that use statement expressions into expressions that use `do{}while(0)`. Reviewed By: larryliu0820 Differential Revision: D64953673
tarun292
force-pushed
the
export-D64953673
branch
from
0b708f6 to
f1ff88c
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
…6503) Summary: Statement expressions are supported in GCC but not in MSVC, so re-writing the macros in core that use statement expressions into expressions that use `do{}while(0)`. Reviewed By: larryliu0820 Differential Revision: D64953673
facebook-github-bot
force-pushed
the
export-D64953673
branch
from
f1ff88c to
f4a2560
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64953673 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64953673 |
tarun292
added a commit
that referenced
this pull request
Oct 29, 2024
…6503) Summary: Statement expressions are supported in GCC but not in MSVC, so re-writing the macros in core that use statement expressions into expressions that use `do{}while(0)`. Reviewed By: larryliu0820 Differential Revision: D64953673
tarun292
force-pushed
the
export-D64953673
branch
from
f4a2560 to
2366e32
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64953673 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
…6503) Summary: Statement expressions are supported in GCC but not in MSVC, so re-writing the macros in core that use statement expressions into expressions that use `do{}while(0)`. Reviewed By: larryliu0820 Differential Revision: D64953673
facebook-github-bot
force-pushed
the
export-D64953673
branch
from
2366e32 to
01482e1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64953673 |
…6503) Summary: Statement expressions are supported in GCC but not in MSVC, so re-writing the macros in core that use statement expressions into expressions that use `do{}while(0)`. Reviewed By: larryliu0820 Differential Revision: D64953673
facebook-github-bot
force-pushed
the
export-D64953673
branch
from
01482e1 to
68714ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64953673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Statement expressions are supported in GCC but not in MSVC, so re-writing the macros in core that use statement expressions into expressions that use
do{}while(0).Differential Revision: D64953673