[ET-VK][AOT] Define pass application order #6577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes The goal of this diff is to enforce a specific structure in how graph transform passes are applied during `vulkan_preprocess`. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied. See the comments in `vulkan_preprocess.py` for more details. Differential Revision: [D65234843](https://our.internmc.facebook.com/intern/diff/D65234843/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6577
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f4a4916 with merge base 1972e69 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65234843 |
SS-JIA
added a commit
that referenced
this pull request
Oct 30, 2024
## Changes The goal of this diff is to enforce a specific structure in how graph transform passes are applied during `vulkan_preprocess`. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied. See the comments in `vulkan_preprocess.py` for more details. Differential Revision: [D65234843](https://our.internmc.facebook.com/intern/diff/D65234843/) ghstack-source-id: 251001207 Pull Request resolved: #6577
## Changes The goal of this diff is to enforce a specific structure in how graph transform passes are applied during `vulkan_preprocess`. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied. See the comments in `vulkan_preprocess.py` for more details. Differential Revision: [D65234843](https://our.internmc.facebook.com/intern/diff/D65234843/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65234843 |
SS-JIA
added a commit
that referenced
this pull request
Oct 30, 2024
Pull Request resolved: #6577 ## Changes The goal of this diff is to enforce a specific structure in how graph transform passes are applied during `vulkan_preprocess`. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied. See the comments in `vulkan_preprocess.py` for more details. Differential Revision: [D65234843](https://our.internmc.facebook.com/intern/diff/D65234843/) ghstack-source-id: 251002582
## Changes The goal of this diff is to enforce a specific structure in how graph transform passes are applied during `vulkan_preprocess`. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied. See the comments in `vulkan_preprocess.py` for more details. Differential Revision: [D65234843](https://our.internmc.facebook.com/intern/diff/D65234843/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65234843 |
junpi3
approved these changes
Oct 31, 2024
## Changes The goal of this diff is to enforce a specific structure in how graph transform passes are applied during `vulkan_preprocess`. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied. See the comments in `vulkan_preprocess.py` for more details. Differential Revision: [D65234843](https://our.internmc.facebook.com/intern/diff/D65234843/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65234843 |
## Changes The goal of this diff is to enforce a specific structure in how graph transform passes are applied during `vulkan_preprocess`. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied. See the comments in `vulkan_preprocess.py` for more details. Differential Revision: [D65234843](https://our.internmc.facebook.com/intern/diff/D65234843/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65234843 |
facebook-github-bot
merged commit 313e46a
into
gh/SS-JIA/131/base
39 of 41 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Oct 31, 2024
Pull Request resolved: #6577 ## Changes The goal of this diff is to enforce a specific structure in how graph transform passes are applied during `vulkan_preprocess`. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied. See the comments in `vulkan_preprocess.py` for more details. ghstack-source-id: 251223076 Differential Revision: [D65234843](https://our.internmc.facebook.com/intern/diff/D65234843/) Co-authored-by: Stephen Jia <ssjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Changes
The goal of this diff is to enforce a specific structure in how graph transform passes are applied during
vulkan_preprocess. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied.See the comments in
vulkan_preprocess.pyfor more details.Differential Revision: D65234843