Make EValue template constructor MSVC friendly #6631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6631
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9fa66ad with merge base 8a4e492 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65402442 |
dbort
approved these changes
Nov 4, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: The current EValue template constructor is not MSVC friendly, in order to make it MSVC friendly had to make some small changes such as: - Using a default template argument (typename = typename std::enable_if<...>::type). This means that the std::enable_if condition is evaluated when the template is instantiated. - Separating the SFINAE condition from the function signature. Reviewed By: dbort Differential Revision: D65402442
facebook-github-bot
force-pushed
the
export-D65402442
branch
from
b4aed27 to
d2ff69d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65402442 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: The current EValue template constructor is not MSVC friendly, in order to make it MSVC friendly had to make some small changes such as: - Using a default template argument (typename = typename std::enable_if<...>::type). This means that the std::enable_if condition is evaluated when the template is instantiated. - Separating the SFINAE condition from the function signature. Reviewed By: dbort Differential Revision: D65402442
tarun292
force-pushed
the
export-D65402442
branch
from
d2ff69d to
8ece7b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65402442 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: The current EValue template constructor is not MSVC friendly, in order to make it MSVC friendly had to make some small changes such as: - Using a default template argument (typename = typename std::enable_if<...>::type). This means that the std::enable_if condition is evaluated when the template is instantiated. - Separating the SFINAE condition from the function signature. Reviewed By: dbort Differential Revision: D65402442
tarun292
force-pushed
the
export-D65402442
branch
from
8ece7b7 to
cfba69f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65402442 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: The current EValue template constructor is not MSVC friendly, in order to make it MSVC friendly had to make some small changes such as: - Using a default template argument (typename = typename std::enable_if<...>::type). This means that the std::enable_if condition is evaluated when the template is instantiated. - Separating the SFINAE condition from the function signature. Reviewed By: dbort Differential Revision: D65402442
tarun292
force-pushed
the
export-D65402442
branch
from
cfba69f to
d97a89d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65402442 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: The current EValue template constructor is not MSVC friendly, in order to make it MSVC friendly had to make some small changes such as: - Using a default template argument (typename = typename std::enable_if<...>::type). This means that the std::enable_if condition is evaluated when the template is instantiated. - Separating the SFINAE condition from the function signature. Reviewed By: dbort Differential Revision: D65402442
facebook-github-bot
force-pushed
the
export-D65402442
branch
from
d97a89d to
8569574
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65402442 |
tarun292
added a commit
that referenced
this pull request
Nov 5, 2024
Summary: The current EValue template constructor is not MSVC friendly, in order to make it MSVC friendly had to make some small changes such as: - Using a default template argument (typename = typename std::enable_if<...>::type). This means that the std::enable_if condition is evaluated when the template is instantiated. - Separating the SFINAE condition from the function signature. Reviewed By: dbort Differential Revision: D65402442
tarun292
force-pushed
the
export-D65402442
branch
from
8569574 to
a411fef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65402442 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Summary: The current EValue template constructor is not MSVC friendly, in order to make it MSVC friendly had to make some small changes such as: - Using a default template argument (typename = typename std::enable_if<...>::type). This means that the std::enable_if condition is evaluated when the template is instantiated. - Separating the SFINAE condition from the function signature. Reviewed By: dbort Differential Revision: D65402442
facebook-github-bot
force-pushed
the
export-D65402442
branch
from
a411fef to
1403a49
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65402442 |
Summary: The current EValue template constructor is not MSVC friendly, in order to make it MSVC friendly had to make some small changes such as: - Using a default template argument (typename = typename std::enable_if<...>::type). This means that the std::enable_if condition is evaluated when the template is instantiated. - Separating the SFINAE condition from the function signature. Reviewed By: dbort Differential Revision: D65402442
facebook-github-bot
force-pushed
the
export-D65402442
branch
from
1403a49 to
9fa66ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65402442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D65402442