Support sym round and ceil #6699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6699
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7b969aa with merge base 8f82198 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65382714 |
GregoryComer
force-pushed
the
export-D65382714
branch
from
d53c9d6 to
aadcddb
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 7, 2024
Summary: Add prim op implementations for sym round and ceil. Support round in pass_base interpreter. Test Plan: Added tests for ceil and round in prim_ops_test.cpp. `buck test executorch/kernels/prim_ops/test:` Differential Revision: D65382714 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65382714
branch
from
aadcddb to
5a28052
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65382714 |
malfet
approved these changes
Nov 7, 2024
| if (a.isDouble()) { | ||
| out = EValue(static_cast<int64_t>(ceil(a.toDouble()))); | ||
| } else { | ||
| ET_CHECK_MSG(false, "%zu", (size_t)a.tag); |
There was a problem hiding this comment.
This feels a bit too succinct, please add some explanation why it's unimportant to have it for other dtypes
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 7, 2024
Summary: Add prim op implementations for sym round and ceil. Support round in pass_base interpreter. Test Plan: Added tests for ceil and round in prim_ops_test.cpp. Round is also test end to end with MSGR ODNC model. `buck test executorch/kernels/prim_ops/test:` Reviewed By: malfet Differential Revision: D65382714 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65382714
branch
from
5a28052 to
562ab87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65382714 |
Summary: Add prim op implementations for sym round and ceil. Support round in pass_base interpreter. Test Plan: Added tests for ceil and round in prim_ops_test.cpp. Round is also test end to end with MSGR ODNC model. `buck test executorch/kernels/prim_ops/test:` Reviewed By: malfet Differential Revision: D65382714 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65382714
branch
from
562ab87 to
7b969aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65382714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add prim op implementations for sym round and ceil. Support round in pass_base interpreter.
Differential Revision: D65382714