Use Linear tiling by default for executorch vulkan tensor images #6838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6838
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 5ba6845 with merge base 6f63893 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65912644 |
nathanaelsee
approved these changes
Nov 14, 2024
yipjustin
approved these changes
Nov 14, 2024
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 14, 2024
…orch#6838) Summary: This diff changes the default image layout for a tensor from TILING_OPTIMAL to TILING_LINEAR. Linear tiling helps improve memory utilization by minimizing texture padding and give better control over texture caching. q_8w_linear op shader and dispatch settings are modified to utilize linearity of texture. Reviewed By: nathanaelsee Differential Revision: D65912644
trivedivivek
force-pushed
the
export-D65912644
branch
from
858ac2e to
754d378
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65912644 |
…orch#6838) Summary: This diff changes the default image layout for a tensor from TILING_OPTIMAL to TILING_LINEAR. Linear tiling helps improve memory utilization by minimizing texture padding and give better control over texture caching. q_8w_linear op shader and dispatch settings are modified to utilize linearity of texture. Reviewed By: nathanaelsee Differential Revision: D65912644
trivedivivek
force-pushed
the
export-D65912644
branch
from
754d378 to
5ba6845
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65912644 |
trivedivivek
changed the title
pytorch-bot
bot
added
ciflow/periodic
module: vulkan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff changes the default image layout for a tensor from TILING_OPTIMAL to TILING_LINEAR.
Linear tiling helps improve memory utilization by minimizing texture padding and give better control over texture caching.
q_8w_linear op shader and dispatch settings are modified to utilize linearity of texture.
Differential Revision: D65912644