Update eager runner to support AttentionSink #6921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the eager runner to support AttentionSink. It also fixes issues in the `chat_completion` function to properly handle the position id. Differential Revision: [D66076486](https://our.internmc.facebook.com/intern/diff/D66076486/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6921
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a8ebf7c with merge base ddec0c7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Nov 17, 2024
Merged
|
This pull request was exported from Phabricator. Differential Revision: D66076486 |
This was referenced Nov 22, 2024
This PR updates the eager runner to support AttentionSink. It also fixes issues in the `chat_completion` function to properly handle the position id. Differential Revision: [D66076486](https://our.internmc.facebook.com/intern/diff/D66076486/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66076486 |
This PR updates the eager runner to support AttentionSink. It also fixes issues in the `chat_completion` function to properly handle the position id. Differential Revision: [D66076486](https://our.internmc.facebook.com/intern/diff/D66076486/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66076486 |
larryliu0820
approved these changes
Dec 2, 2024
This PR updates the eager runner to support AttentionSink. It also fixes issues in the `chat_completion` function to properly handle the position id. Differential Revision: [D66076486](https://our.internmc.facebook.com/intern/diff/D66076486/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66076486 |
This PR updates the eager runner to support AttentionSink. It also fixes issues in the `chat_completion` function to properly handle the position id. Differential Revision: [D66076486](https://our.internmc.facebook.com/intern/diff/D66076486/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66076486 |
This PR updates the eager runner to support AttentionSink. It also fixes issues in the `chat_completion` function to properly handle the position id. Differential Revision: [D66076486](https://our.internmc.facebook.com/intern/diff/D66076486/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66076486 |
facebook-github-bot
merged commit 49a7595
into
gh/helunwencser/78/base
41 of 43 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
helunwencser
added a commit
that referenced
this pull request
Dec 3, 2024
* Transform model to be able to use Attention Sink Pull Request resolved: #6700 This PR adds necessary functions for transforming the model to be able to use Attention Sink. ghstack-source-id: 256108077 @exported-using-ghexport Differential Revision: [D65571289](https://our.internmc.facebook.com/intern/diff/D65571289/) * Update eager runner to support AttentionSink Pull Request resolved: #6921 This PR updates the eager runner to support AttentionSink. It also fixes issues in the `chat_completion` function to properly handle the position id. ghstack-source-id: 256108078 Differential Revision: [D66076486](https://our.internmc.facebook.com/intern/diff/D66076486/) * add eval for attention sink (#7150) Pull Request resolved: #7070 This PR adds the function to evaluate the model's perplexity when AttentionSink is enabled. This is mostly copied from https://github.com/mit-han-lab/streaming-llm/blob/main/examples/eval_long_ppl.py which is used by the AttentionSink paper to evaluate the model's perplexity when AttentionSink is enabled. ghstack-source-id: 256108079 @exported-using-ghexport Differential Revision: [D66474732](https://our.internmc.facebook.com/intern/diff/D66474732/) Co-authored-by: Lunwen He <lwhecser@gmail.com> --------- Co-authored-by: Lunwen He <lwhecser@gmail.com>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
This PR updates the eager runner to support AttentionSink. It also fixes issues in the `chat_completion` function to properly handle the position id. Differential Revision: [D66076486](https://our.internmc.facebook.com/intern/diff/D66076486/) ghstack-source-id: 254019783 Pull Request resolved: pytorch/executorch#6921
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#6921 This PR updates the eager runner to support AttentionSink. It also fixes issues in the `chat_completion` function to properly handle the position id. ghstack-source-id: 256108078 Differential Revision: [D66076486](https://our.internmc.facebook.com/intern/diff/D66076486/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR updates the eager runner to support AttentionSink.
It also fixes issues in the
chat_completionfunction to properly handle the position id.Differential Revision: D66076486