Check group size is divisible by 32 #6941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6941
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ebaad4d with merge base be0bd75 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66131456 |
malfet
approved these changes
Nov 18, 2024
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Dec 6, 2024
Summary: Currently when checking the per_channel_group quantization parameters we don't check that the group_size must be a multiple of 32. This constraint was added after we implemented the original checks here. Let's add multiple of 32 here. Reviewed By: malfet, digantdesai Differential Revision: D66131456
mcr229
force-pushed
the
export-D66131456
branch
from
3aebc60 to
c44ef84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66131456 |
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Dec 6, 2024
Summary: Currently when checking the per_channel_group quantization parameters we don't check that the group_size must be a multiple of 32. This constraint was added after we implemented the original checks here. Let's add multiple of 32 here. Reviewed By: malfet, digantdesai Differential Revision: D66131456
mcr229
force-pushed
the
export-D66131456
branch
from
c44ef84 to
729fa0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66131456 |
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Dec 6, 2024
Summary: Currently when checking the per_channel_group quantization parameters we don't check that the group_size must be a multiple of 32. This constraint was added after we implemented the original checks here. Let's add multiple of 32 here. Reviewed By: malfet, digantdesai Differential Revision: D66131456
mcr229
force-pushed
the
export-D66131456
branch
from
729fa0f to
f32b984
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66131456 |
Summary: Currently when checking the per_channel_group quantization parameters we don't check that the group_size must be a multiple of 32. This constraint was added after we implemented the original checks here. Let's add multiple of 32 here. Reviewed By: malfet, digantdesai Differential Revision: D66131456
mcr229
force-pushed
the
export-D66131456
branch
from
f32b984 to
ebaad4d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66131456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently when checking the per_channel_group quantization parameters we don't check that the group_size must be a multiple of 32. This constraint was added after we implemented the original checks here. Let's add multiple of 32 here.
Reviewed By: digantdesai
Differential Revision: D66131456