Skip to content

Minor perf improvements to quantized linear 8 bit shader. #6944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

Minor perf improvements to quantized linear 8 bit shader. #6944

merged 1 commit into from
Nov 21, 2024

Conversation

@trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented Nov 19, 2024

Summary: This diff slightly improves the performance of quantized linear op by reducing few heavy math ops such as mod and divide.

Differential Revision: D66134239

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6944

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 6f76a0b with merge base bafae87 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D66134239

@github-actions
Copy link

github-actions bot commented Nov 19, 2024

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

trivedivivek added a commit to trivedivivek/executorch that referenced this pull request Nov 19, 2024
@trivedivivek @facebook-github-bot
Minor perf improvements to quantized linear 8 bit shader. (pytorch#6944)
ba4cba6 
Summary:

This diff slightly improves the performance of quantized linear op by reducing few heavy math ops such as mod and divide.

Reviewed By: Polyomino, SS-JIA

Differential Revision: D66134239
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D66134239

trivedivivek added a commit to trivedivivek/executorch that referenced this pull request Nov 19, 2024
@trivedivivek @facebook-github-bot
Minor perf improvements to quantized linear 8 bit shader. (pytorch#6944)
7a8927d 
Summary:

This diff slightly improves the performance of quantized linear op by reducing few heavy math ops such as mod and divide.

Reviewed By: Polyomino, SS-JIA

Differential Revision: D66134239
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D66134239

trivedivivek added a commit to trivedivivek/executorch that referenced this pull request Nov 20, 2024
@trivedivivek @facebook-github-bot
Minor perf improvements to quantized linear 8 bit shader. (pytorch#6944)
418b3db 
Summary:

This diff slightly improves the performance of quantized linear op by reducing few heavy math ops such as mod and divide.

Reviewed By: Polyomino, SS-JIA

Differential Revision: D66134239
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2024

This pull request was exported from Phabricator. Differential Revision: D66134239

trivedivivek added a commit to trivedivivek/executorch that referenced this pull request Nov 20, 2024
@trivedivivek @facebook-github-bot
Minor perf improvements to quantized linear 8 bit shader. (pytorch#6944)
c2b053d 
Summary:

This diff slightly improves the performance of quantized linear op by reducing few heavy math ops such as mod and divide.

Reviewed By: Polyomino, SS-JIA

Differential Revision: D66134239
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2024

This pull request was exported from Phabricator. Differential Revision: D66134239

@trivedivivek @facebook-github-bot
Minor perf improvements to quantized linear 8 bit shader. (pytorch#6944)
6f76a0b 
Summary:

This diff slightly improves the performance of quantized linear op by reducing few heavy math ops such as mod and divide.

Reviewed By: Polyomino, SS-JIA

Differential Revision: D66134239
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2024

This pull request was exported from Phabricator. Differential Revision: D66134239

@facebook-github-bot facebook-github-bot merged commit 3a35889 into pytorch:main Nov 21, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trivedivivek @facebook-github-bot @SS-JIA