Skip to content

Conversation

@anijain2305
Copy link
Contributor

Summary: This issue was discovered when we tried to land https://www.internalfb.com/diff/D66189091. There is nothing wrong with D66189091, it just changes the way Dynamo invalidates its cache entry. However, it upsets these tests because they unintentionally rely on the Dynamo old behavior of invalidting cache entries.

Reviewed By: kimishpatel

Differential Revision: D66255174

Summary: This issue was discovered when we tried to land https://www.internalfb.com/diff/D66189091. There is nothing wrong with D66189091, it just changes the way Dynamo invalidates its cache entry. However, it upsets these tests because they unintentionally rely on the Dynamo old behavior of invalidting cache entries.

Reviewed By: kimishpatel

Differential Revision: D66255174
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6990

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 5 New Failures, 2 Unrelated Failures

As of commit 9110c76 with merge base 359e9d3 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66255174

@facebook-github-bot facebook-github-bot merged commit e721945 into pytorch:main Nov 21, 2024
35 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants