Fix compilation crash on iOS<16 #7007
Conversation
Summary: Added conditional compilation to mitigate a crash on iOS<16 where the used function is not present. Fixes pytorch#6984 Bonus: report back the error in case of compilation errors, which was missing Differential Revision: D66294248
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7007
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New FailuresAs of commit 8f75eef with merge base 270d055 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66294248 |
|
@pytorchbot label "module: coreml" |
pytorch-bot
bot
added
the
module: coreml
|
@pytorchbot label "release notes: backends" |
| return nil; | ||
| } | ||
| } else { | ||
| result = [MLModel compileModelAtURL:modelURL error:&localError]; |
There was a problem hiding this comment.
This doesn't have the timeout logic, but it was crashing before, so I think we can go with this for now to mitigate the issue and improve it later.
cymbalrush
left a comment
cymbalrush
left a comment
There was a problem hiding this comment.
Thank you! Is iOS 15 the minimum deployment target, I always thought it's iOS 16
|
@cymbalrush Thank you for the review :) I think it is iOS 13 |
3 participants
Summary:
Added conditional compilation to mitigate a crash on iOS<16 where the used function is not present.
Fixes #6984
Bonus: report back the error in case of compilation errors, which was missing
Differential Revision: D66294248