Use a template for Apple test spec #7151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7151
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ee46cc5 with merge base 0a12e33 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
huydhn
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
shoumikhin
approved these changes
Dec 3, 2024
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
guangy10
reviewed
Dec 3, 2024
| if-no-files-found: error | ||
| path: extension/benchmark/apple/Benchmark/default-ios-device-farm-appium-test-spec.yml | ||
|
|
||
| validate-apple-test-spec: |
There was a problem hiding this comment.
Same comment as that in PR#7091: #7091 (comment)
Other than that looks good
There was a problem hiding this comment.
Same test that trigger apple-perf workflow https://github.com/pytorch/executorch/actions/runs/12150085461 and clean up upload-apple-test-specs
guangy10
approved these changes
Dec 4, 2024
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the iOS counterpart of #7091. This setup helps address the 4GB file size limit enforced by AWS and also fixes the usage of .ci/scripts/test_llama.sh after #6870.
Testing