Use libtorch target in generated operator tests/benchmarks instead of custom op lib target #7245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… custom op lib target Summary: TSIA. Previously, a custom ATen operator library target was being used as a dependency in the generated operator tests to access ATen operator implementations. However, it seems that using the `libtorch` target works as well. Change everything to just use `libtorch` to 1. Simplify dependencies 2. The custom ATen operator library target does not build on Windows for some reason Differential Revision: D66964157
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7245
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit d75912b with merge base 4adbdce ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66964157 |
junpi3
approved these changes
Dec 9, 2024
nathanaelsee
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TSIA. Previously, a custom ATen operator library target was being used as a dependency in the generated operator tests to access ATen operator implementations. However, it seems that using the
libtorchtarget works as well.Change everything to just use
libtorchtoDifferential Revision: D66964157