Arm backend: Remove running examples/arm/setup.sh in the github docker #7290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will move Arm PR testing to use an empty docker and examples/arm/setup.sh will always run from a fresh setup when testing a PR to minimize the risk of and old run of examples/arm/setup.sh done during docker creation colliding PR testing, or being out of sync with it. The different runs of examples/arm/setup.sh also used different install folders and that might break stuff even more. Signed-off-by: Zingo Andersen <zingo.andersen@arm.com> Change-Id: I795078d3d764a3f7ad5d6043fb8b70290af5789f
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7290
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c538e91 with merge base de74961 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
partner: arm
freddan80
approved these changes
Dec 11, 2024
…arm/setup.sh-in-the-github-docker
digantdesai
reviewed
Dec 13, 2024
digantdesai
approved these changes
Dec 13, 2024
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
Thanks let's hope we can reduce frequency for the docker build issues.
zingo
deleted the
Arm-backend-Remove-running-examples/arm/setup.sh-in-the-github-docker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will move Arm PR testing to use an empty docker and examples/arm/setup.sh will always run from a fresh setup when testing a PR to minimize the risk of and old run of examples/arm/setup.sh done during docker creation colliding PR testing, or being out of sync with it. The different runs of examples/arm/setup.sh also used different install folders and that might break stuff even more.