Update RemovePermutesAroundElementwiseOps to work with view as well #7407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7407
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2058d8b with merge base 34e0570 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67471456 |
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Dec 19, 2024
…ytorch#7407) Summary: The RemovePermutesAroundElementwiseOps pass was working well for permutes, but sometimes permutes get optimized into `view_copy` if the dimension being moved doesn't change the byte-level arrangement of the Tensor. Handle this case so we can remove more functions in these chains. Differential Revision: D67471456
dulinriley
force-pushed
the
export-D67471456
branch
from
8b70f4b to
400dba5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67471456 |
zonglinpeng
approved these changes
Dec 19, 2024
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Dec 19, 2024
…ytorch#7407) Summary: The RemovePermutesAroundElementwiseOps pass was working well for permutes, but sometimes permutes get optimized into `view_copy` if the dimension being moved doesn't change the byte-level arrangement of the Tensor. Handle this case so we can remove more functions in these chains. Reviewed By: zonglinpeng Differential Revision: D67471456
dulinriley
force-pushed
the
export-D67471456
branch
from
400dba5 to
e9e375c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67471456 |
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Dec 20, 2024
…ytorch#7407) Summary: The RemovePermutesAroundElementwiseOps pass was working well for permutes, but sometimes permutes get optimized into `view_copy` if the dimension being moved doesn't change the byte-level arrangement of the Tensor. Handle this case so we can remove more functions in these chains. Reviewed By: zonglinpeng Differential Revision: D67471456
dulinriley
force-pushed
the
export-D67471456
branch
from
e9e375c to
5f68fe7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67471456 |
…ytorch#7407) Summary: The RemovePermutesAroundElementwiseOps pass was working well for permutes, but sometimes permutes get optimized into `view_copy` if the dimension being moved doesn't change the byte-level arrangement of the Tensor. Handle this case so we can remove more functions in these chains. Reviewed By: zonglinpeng Differential Revision: D67471456
dulinriley
force-pushed
the
export-D67471456
branch
from
5f68fe7 to
2058d8b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67471456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The RemovePermutesAroundElementwiseOps pass was working well for
permutes, but sometimes permutes get optimized into
view_copyif thedimension being moved doesn't change the byte-level arrangement of the
Tensor.
Handle this case so we can remove more functions in these chains.
Differential Revision: D67471456