Fix list assumption about permute arguments #7472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7472
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 40d7846 with merge base 3ef78ee ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67765363 |
Vysarat
approved these changes
Jan 2, 2025
Summary: Permute nodes can have either a list or tuple as the second argument, and the debug handle may or may not exist on dq nodes. Make these passes a bit more robust in what they accept. Reviewed By: Vysarat Differential Revision: D67765363
dulinriley
force-pushed
the
export-D67765363
branch
from
b317063 to
40d7846
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67765363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Permute nodes can have either a list or tuple as the second argument, and the debug
handle may or may not exist on dq nodes. Make these passes a bit more robust in what
they accept.
Reviewed By: Vysarat
Differential Revision: D67765363