Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

  • Add ai-edge-model-explorer as development requirement
  • Add lightweight wrapper around model-explorer in devtools
  • Use it in .visualize() call in XNNPack tester
  • Add tests. The actual call to model-explorer is mocked, since
    getting it to run in ci did not work out. However, asserting
    that the model actually loads properly needs visual inspection anyways.
    Instead, visualization_utils_test.py can be run locally.
  • Add two context managers for starting model-explorer servers,
    currently only used for testing but might be useful.

See discussion here: #6750

zingo and others added 2 commits January 7, 2025 16:34
This fix a problem with TorchAudio beeing out of sync and causing c++ build problems.

Signed-off-by: Zingo Andersen <zingo.andersen@arm.com>
Change-Id: Ia283c652918d17ed7c40ec877def0a88091e5d7a
- Add ai-edge-model-explorer as development requirement
- Add lightweight wrapper around model-explorer in devtools
- Use it in .visualize() call in XNNPack tester
- Add tests. The actual call to model-explorer is mocked, since
  getting it to run in ci did not work out. However, asserting
  that the model actually loads properly needs visual inspection anyways.
  Instead, visualization_utils_test.py can be run locally.
- Add two context managers for starting model-explorer servers,
  currently only used for testing but might be useful.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I3fc0efb3a2012b038f699f7737c4d97c5039df40
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7553

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2025
@github-actions
Copy link

github-actions bot commented Jan 8, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants