- 
                Notifications
    
You must be signed in to change notification settings  - Fork 710
 
[Arm backend] Refactor runner_utils, removing RunnerUtil #7722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    As the execution of models on reference_model or on FVP has simplified, there is no longer need for a class to handle the execution. Instead, running a model should should only be a function call with the model, inputs and some metadata. This makes it easier to reuse runner_utils. Change-Id: Ib6addbdaa2fa492c356e92ad1b95c2dac2885b9d
          
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7722
 Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Cancelled Jobs, 1 Unrelated FailureAs of commit dd6e47e with merge base fedb035 ( NEW FAILURE - The following job has failed:
 
 CANCELLED JOBS - The following jobs were cancelled. Please retry:
 
 BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures 
 
 This comment was automatically generated by Dr. CI and updates every 15 minutes.  | 
    
              
                    zingo
  
              
              approved these changes
              
                  
                    Jan 17, 2025 
                  
              
              
            
            
| 
           Unrelated ci failure.  | 
    
    
  YIWENX14 
      pushed a commit
      that referenced
      this pull request
    
      Jan 28, 2025 
    
    
      
  
    
      
    
  
As the execution of models on reference_model or on FVP has simplified, there is no longer need for a class to handle the execution. Instead, running a model should should only be a function call with the model, inputs and some metadata. This makes it easier to reuse runner_utils.
    
  zonglinpeng 
      pushed a commit
        to zonglinpeng/executorch
      that referenced
      this pull request
    
      Jan 30, 2025 
    
    
      
  
    
      
    
  
As the execution of models on reference_model or on FVP has simplified, there is no longer need for a class to handle the execution. Instead, running a model should should only be a function call with the model, inputs and some metadata. This makes it easier to reuse runner_utils.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    ciflow/trunk
  
    CLA Signed
  This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. 
  
    partner: arm
  For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm 
  
    topic: not user facing
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
As the execution of models on reference_model
or on FVP has simplified, there is no longer need
for a class to handle the execution.
Instead, running a model should should only be a
function call with the model, inputs and some metadata. This makes it easier to reuse runner_utils.
Change-Id: Ib6addbdaa2fa492c356e92ad1b95c2dac2885b9d
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218