Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Jan 17, 2025

As the execution of models on reference_model
or on FVP has simplified, there is no longer need
for a class to handle the execution.
Instead, running a model should should only be a
function call with the model, inputs and some metadata. This makes it easier to reuse runner_utils.

Change-Id: Ib6addbdaa2fa492c356e92ad1b95c2dac2885b9d

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

As the execution of models on reference_model
or on FVP has simplified, there is no longer need
for a class to handle the execution.
Instead, running a model should should only be a
function call with the model, inputs and some metadata.
This makes it easier to reuse runner_utils.

Change-Id: Ib6addbdaa2fa492c356e92ad1b95c2dac2885b9d
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Jan 17, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7722

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Cancelled Jobs, 1 Unrelated Failure

As of commit dd6e47e with merge base fedb035 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
@Erik-Lundell
Copy link
Collaborator Author

Unrelated ci failure.

@zingo zingo merged commit f4e77c7 into pytorch:main Jan 21, 2025
102 of 108 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
As the execution of models on reference_model
or on FVP has simplified, there is no longer need
for a class to handle the execution.
Instead, running a model should should only be a
function call with the model, inputs and some metadata.
This makes it easier to reuse runner_utils.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
As the execution of models on reference_model
or on FVP has simplified, there is no longer need
for a class to handle the execution.
Instead, running a model should should only be a
function call with the model, inputs and some metadata.
This makes it easier to reuse runner_utils.
@Erik-Lundell Erik-Lundell deleted the remove_runner_util branch July 31, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants