[ET-VK][ez] Add back tensor dim check #7938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context Vulkan cannot represent higher dimensional tensors (tensors with dim > 4) at the moment, but due to some refactors implemented last year the partitioner check to avoid lowering ops that involve high dimensional tensors was accidentally removed. This diff adds back the check, as well as a test to verify that high dimensional tensors do not get lowered. Differential Revision: [D68630966](https://our.internmc.facebook.com/intern/diff/D68630966/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7938
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ab55b29 with merge base 57ef834 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SS-JIA
added a commit
that referenced
this pull request
Jan 24, 2025
## Context Vulkan cannot represent higher dimensional tensors (tensors with dim > 4) at the moment, but due to some refactors implemented last year the partitioner check to avoid lowering ops that involve high dimensional tensors was accidentally removed. This diff adds back the check, as well as a test to verify that high dimensional tensors do not get lowered. Differential Revision: [D68630966](https://our.internmc.facebook.com/intern/diff/D68630966/) ghstack-source-id: 262922165 Pull Request resolved: #7938
|
This pull request was exported from Phabricator. Differential Revision: D68630966 |
This PR needs a
|
junpi3
approved these changes
Jan 24, 2025
## Context Vulkan cannot represent higher dimensional tensors (tensors with dim > 4) at the moment, but due to some refactors implemented last year the partitioner check to avoid lowering ops that involve high dimensional tensors was accidentally removed. This diff adds back the check, as well as a test to verify that high dimensional tensors do not get lowered. Differential Revision: [D68630966](https://our.internmc.facebook.com/intern/diff/D68630966/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jan 24, 2025
Pull Request resolved: #7938 ## Context Vulkan cannot represent higher dimensional tensors (tensors with dim > 4) at the moment, but due to some refactors implemented last year the partitioner check to avoid lowering ops that involve high dimensional tensors was accidentally removed. This diff adds back the check, as well as a test to verify that high dimensional tensors do not get lowered. ghstack-source-id: 262929769 @exported-using-ghexport Differential Revision: [D68630966](https://our.internmc.facebook.com/intern/diff/D68630966/)
|
This pull request was exported from Phabricator. Differential Revision: D68630966 |
facebook-github-bot
merged commit b4f7994
into
gh/SS-JIA/172/base
44 of 47 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Jan 24, 2025
Pull Request resolved: #7938 ## Context Vulkan cannot represent higher dimensional tensors (tensors with dim > 4) at the moment, but due to some refactors implemented last year the partitioner check to avoid lowering ops that involve high dimensional tensors was accidentally removed. This diff adds back the check, as well as a test to verify that high dimensional tensors do not get lowered. ghstack-source-id: 262929769 @exported-using-ghexport Differential Revision: [D68630966](https://our.internmc.facebook.com/intern/diff/D68630966/) Co-authored-by: Stephen Jia <ssjia@meta.com>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Pull Request resolved: #7938 ## Context Vulkan cannot represent higher dimensional tensors (tensors with dim > 4) at the moment, but due to some refactors implemented last year the partitioner check to avoid lowering ops that involve high dimensional tensors was accidentally removed. This diff adds back the check, as well as a test to verify that high dimensional tensors do not get lowered. ghstack-source-id: 262929769 @exported-using-ghexport Differential Revision: [D68630966](https://our.internmc.facebook.com/intern/diff/D68630966/) Co-authored-by: Stephen Jia <ssjia@meta.com>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: pytorch#7938 ## Context Vulkan cannot represent higher dimensional tensors (tensors with dim > 4) at the moment, but due to some refactors implemented last year the partitioner check to avoid lowering ops that involve high dimensional tensors was accidentally removed. This diff adds back the check, as well as a test to verify that high dimensional tensors do not get lowered. ghstack-source-id: 262929769 @exported-using-ghexport Differential Revision: [D68630966](https://our.internmc.facebook.com/intern/diff/D68630966/) Co-authored-by: Stephen Jia <ssjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Vulkan cannot represent higher dimensional tensors (tensors with dim > 4) at the moment, but due to some refactors implemented last year the partitioner check to avoid lowering ops that involve high dimensional tensors was accidentally removed.
This diff adds back the check, as well as a test to verify that high dimensional tensors do not get lowered.
Differential Revision: D68630966