Skip to content

Update shim to unbreak OSS tests buck build #8362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Update shim to unbreak OSS tests buck build #8362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22efe6f
Update
swolchok Feb 11, 2025
4fa689d
Update
swolchok Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions shim/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
load("@prelude//platforms:defs.bzl", "execution_platform")
load("@prelude//tests:test_toolchain.bzl", "noop_test_toolchain")
load("@prelude//toolchains:cxx.bzl", "system_cxx_toolchain")
load("@prelude//toolchains:genrule.bzl", "system_genrule_toolchain")
load("@prelude//toolchains:go.bzl", "system_go_toolchain")
Expand All @@ -8,6 +9,10 @@ load("@prelude//toolchains:python.bzl", "system_python_bootstrap_toolchain", "sy
load("@prelude//toolchains:remote_test_execution.bzl", "remote_test_execution_toolchain")
load("@prelude//toolchains:rust.bzl", "system_rust_toolchain")

# TODO: sync this directory with https://github.com/facebook/buck2-shims-meta.
# Internal context:
# https://fb.workplace.com/groups/222849770514616/posts/600883896044533/

oncall("executorch")

system_cxx_toolchain(
Expand Down Expand Up @@ -74,3 +79,8 @@ execution_platform(
use_windows_path_separators = host_info().os.is_windows,
visibility = ["PUBLIC"],
)

noop_test_toolchain(
Copy link
Contributor

@kimishpatel kimishpatel Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a comment here similar to what you said in summary so that in case you dont pick up the followup action item, someone else can

name = "test",
visibility = ["PUBLIC"],
)
Loading