Skip to content

Fix HiFi relu for int8 #8424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix HiFi relu for int8 #8424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 7 additions & 26 deletions backends/cadence/hifi/operators/op_quantized_relu_out.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,12 @@ void quantized_relu_per_tensor_out(
const int64_t out_multiplier,
const int64_t out_shift,
Tensor& output) {
const uint8_t _in_zero_point = static_cast<uint8_t>(in_zero_point);
const uint8_t _out_zero_point = static_cast<uint8_t>(out_zero_point);
const int32_t _out_multiplier = static_cast<int32_t>(out_multiplier);
const int32_t _out_shift = static_cast<int32_t>(out_shift);
const int32_t _out_multiplier = static_cast<int32_t>(out_multiplier);
const int32_t _out_shift = static_cast<int32_t>(out_shift);

if (input.scalar_type() == executorch::aten::ScalarType::Byte) {
const uint8_t _in_zero_point = static_cast<uint8_t>(in_zero_point);
const uint8_t _out_zero_point = static_cast<uint8_t>(out_zero_point);
const uint8_t* p_in = input.const_data_ptr<uint8_t>();
uint8_t* p_out = output.mutable_data_ptr<uint8_t>();

Expand All @@ -48,6 +49,8 @@ void quantized_relu_per_tensor_out(
ET_CHECK_MSG(ret_val == 0, "An internal error occured");

} else if (input.scalar_type() == executorch::aten::ScalarType::Char) {
const int8_t _in_zero_point = static_cast<int8_t>(in_zero_point);
const int8_t _out_zero_point = static_cast<int8_t>(out_zero_point);
const int8_t* p_in = input.const_data_ptr<int8_t>();
int8_t* p_out = output.mutable_data_ptr<int8_t>();

Expand All @@ -72,28 +75,6 @@ void quantized_relu_per_tensor_out(
}
}

void quantized_relu_per_tensor_out(
KernelRuntimeContext& ctx,
const Tensor& input,
const Tensor& in_zero_point,
const int64_t out_zero_point,
const Tensor& out_multiplier,
const Tensor& out_shift,
Tensor& output) {
int8_t _in_zero_point = in_zero_point.const_data_ptr<int8_t>()[0];
int32_t _out_multiplier = out_multiplier.const_data_ptr<int32_t>()[0];
int32_t _out_shift = out_shift.const_data_ptr<int32_t>()[0];

quantized_relu_per_tensor_out(
ctx,
input,
_in_zero_point,
out_zero_point,
_out_multiplier,
_out_shift,
output);
}

} // namespace native
} // namespace HiFi
} // namespace impl
Expand Down
Loading