Skip to content

Export Mimi model to ExecuTorch #8753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Export Mimi model to ExecuTorch #8753

merged 1 commit into from
Mar 13, 2025

Conversation

@iseeyuan
Copy link
Contributor

@iseeyuan iseeyuan commented Feb 27, 2025 •
edited
Loading

Summary

Export Mimi model to ExecuTorch

Test plan

python -m unittest examples.models.moshi.mimi.test_mimi

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8753

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a66a26c with merge base 1a918c7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2025
@iseeyuan iseeyuan linked an issue Feb 27, 2025 that may be closed by this pull request
Support Mimi model inside Moshi #8373
Closed
@iseeyuan iseeyuan force-pushed the mimi branch 3 times, most recently from 1fe92ee to 27e557e Compare March 5, 2025 00:17
@iseeyuan iseeyuan moved this from To triage to In progress in ExecuTorch Core Mar 11, 2025
@iseeyuan iseeyuan moved this to In Progress in etLLM: LLMs via ExecuTorch Mar 11, 2025
@facebook-github-bot
Copy link
Contributor

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@iseeyuan
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@iseeyuan iseeyuan force-pushed the mimi branch 4 times, most recently from 0857c3c to 2657110 Compare March 13, 2025 02:21
@iseeyuan iseeyuan changed the title [WIP] Export Mimi model to ExecuTorch Export Mimi model to ExecuTorch Mar 13, 2025
@facebook-github-bot
Copy link
Contributor

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@winskuo-quic
Copy link
Collaborator

Hi @iseeyuan,
Thank you so much for sharing how you verified the encoder and decoder are working as expected earlier today!
I have verified the decoder lowered by QNN and it seems like I can get some reasonable results, although the results still having some noises.
I have also successfully exported the encoder and will start working on lowering it to QNN.
I will let you know when the PR is ready.
Thanks.

@facebook-github-bot
Copy link
Contributor

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jackzhxng
jackzhxng reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do this pin bump in a separate PR!

@facebook-github-bot facebook-github-bot merged commit 27bacff into main Mar 13, 2025
53 checks passed
@facebook-github-bot facebook-github-bot deleted the mimi branch March 13, 2025 23:20
@github-project-automation github-project-automation bot moved this from In Progress to Done in etLLM: LLMs via ExecuTorch Mar 13, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in ExecuTorch Core Mar 13, 2025
@winskuo-quic winskuo-quic mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackzhxng jackzhxng jackzhxng left review comments

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

ExecuTorch Core
Status: Done
etLLM: LLMs via ExecuTorch
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Mimi model inside Moshi

5 participants

@iseeyuan @facebook-github-bot @winskuo-quic @larryliu0820 @jackzhxng