Include custom ops in xnn_executor_runner if they're built #9069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9069
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7fcc04e with merge base 94a8bc7 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
iseeyuan
reviewed
Mar 8, 2025
backends/xnnpack/CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| if(EXECUTORCH_BUILD_KERNELS_CUSTOM) | ||
| list(APPEND xnn_executor_runner_libs custom_ops) |
Contributor
There was a problem hiding this comment.
Suggested change
| list(APPEND xnn_executor_runner_libs custom_ops) | |
| list(APPEND xnn_executor_runner_libs $<LINK_LIBRARY:WHOLE_ARCHIVE,custom_ops>) |
Contributor
There was a problem hiding this comment.
The above diff works for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(We should probably merge xnn_executor_runner and executor_runner if there's no particular use for a portable-only runner, but hey this is an incremental improvement.)