Skip to content

set -x in build_apple_frameworks.sh #9326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolchok merged 2 commits into from
Mar 27, 2025
Merged

set -x in build_apple_frameworks.sh #9326

swolchok merged 2 commits into from
Mar 27, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 17, 2025

This causes commands to be echoed as they are executed, making it easier to track progress in CI.

@swolchok
Update
a64a071 
[ghstack-poisoned]
@swolchok swolchok requested a review from GregoryComer as a code owner March 17, 2025 18:26
@swolchok
Copy link
Contributor Author

swolchok commented Mar 17, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from kirklandsign as a code owner March 17, 2025 18:26
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9326

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
swolchok added a commit that referenced this pull request Mar 17, 2025
@swolchok
set -x in build_apple_frameworks.sh
fe6b18b 
This causes commands to be echoed as they are executed, making it easier to track progress in CI.

ghstack-source-id: 44c01e7
ghstack-comment-id: 2730474062
Pull Request resolved: #9326
@swolchok swolchok requested a review from shoumikhin March 17, 2025 18:26
@swolchok
Update
85db9e5 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 27, 2025
@swolchok
set -x in build_apple_frameworks.sh
82886d9 
This causes commands to be echoed as they are executed, making it easier to track progress in CI.

ghstack-source-id: c75e193
ghstack-comment-id: 2730474062
Pull Request resolved: #9326
@swolchok
Copy link
Contributor Author

swolchok commented Mar 27, 2025

has previous green CI run and is just a script change, merging

@swolchok swolchok merged commit 01f5599 into main Mar 27, 2025
82 checks passed
@swolchok swolchok deleted the gh/swolchok/372/head branch March 27, 2025 15:39
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
@swolchok @kirklandsign
set -x in build_apple_frameworks.sh (#9326)
1485e81 
This causes commands to be echoed as they are executed, making it easier
to track progress in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jathu jathu jathu approved these changes

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@shoumikhin shoumikhin Awaiting requested review from shoumikhin

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @jathu @facebook-github-bot