an option to raise exception if oom happens during fairseq.trainer.train_step #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yqwangustc
force-pushed
the
export-D15170357
branch
from
b92af38 to
4ef3594
Compare
yqwangustc
force-pushed
the
export-D15170357
branch
from
4ef3594 to
9c93b9a
Compare
yqwangustc
force-pushed
the
export-D15170357
branch
from
9c93b9a to
80c81c3
Compare
…ain_step (facebookresearch#2) Summary: Pull Request resolved: fairinternal/fairspeq#2 Pull Request resolved: facebookresearch#689 We found not raising OOM during trainer.train_step causes various issue, including NCCL hangs / gloo sync errors because gradient is not synced properly. Before we found the root cause, let's give users an option to raise OOMs. Reviewed By: jmp84 Differential Revision: D15170357 fbshipit-source-id: 1c3defd70bf97b2f4e2f1b39661c735907258194
yqwangustc
force-pushed
the
export-D15170357
branch
from
80c81c3 to
91cbb44
Compare
Contributor
|
This pull request has been merged in a2901f9. |
Harleen8118
pushed a commit
to Harleen8118/IBERT
that referenced
this pull request
Jun 26, 2025
…ain_step (#2) Summary: Pull Request resolved: fairinternal/fairspeq#2 Pull Request resolved: facebookresearch/fairseq#689 We found not raising OOM during trainer.train_step causes various issue, including NCCL hangs / gloo sync errors because gradient is not synced properly. Before we found the root cause, let's give users an option to raise OOMs. Reviewed By: jmp84 Differential Revision: D15170357 fbshipit-source-id: 3e15e4e111a8380612157955509c39821a216ec4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We found not raising OOM during trainer.train_step causes various
issue, including NCCL hangs / gloo sync errors because gradient is not synced
properly. Before we found the root cause, let's give users an option to raise
OOMs.
Differential Revision: D15170357