Skip to content
This repository was archived by the owner on Aug 21, 2025. It is now read-only.
This repository was archived by the owner on Aug 21, 2025. It is now read-only.

Audit CompositeImplicitAutograd ops that do not have a batching rule, add them to BatchRulesDecomposition #1087

@zou3519

Description

@zou3519

This is low hanging fruit: there are a number of CompositeImplicitAutograd ops that do not have a batching rule. We should just add all of them to BatchRulesDecomposition. Should be easy to detect using testing similar to what @srossross did in https://github.com/pytorch/pytorch/pull/89465/files

Here are a couple of things to be careful of:

  • If the op has an OpInfo, then we're good (because we have test coverage)
  • If there has no test coverage, then ideally we would add an OpInfo. This is because not all CompositeImplicitAutograd operations are "Composite Compliant"
  • If there is no test coverage, an alternative to adding an OpInfo is to just read the code and eyeball if it is composite compliant or not. We would prefer having an OpInfo to this option.

Metadata

Metadata

Assignees

No one assigned

    Labels

    actionableIt is clear what should be done for this issuehigh priorityThese issues are at the top of mind for us.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions