build rccl module only when USE_RCCL is ON #325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The original code cannot correctly check whether the user has specified env var ROCM_PATH, thus always used the default /opt/rocm incorrectly. Differential Revision: D35636873 fbshipit-source-id: b6dc031f335bcbf3f1d32ee6f8b84d6a7ebb78b3
Summary: Current code always builds nccl module as long as USE_ROCM is ON. However, we should build it only when USE_RCCL is ON. This patch fixes it by adding the hipified nccl files in nccl/CMakeLists.txt which will be included only when USE_RCCL is ON. Differential Revision: D35636872 fbshipit-source-id: 936f61fef5808431ace35d2da916762875b65b11
|
This pull request was exported from Phabricator. Differential Revision: D35636872 |
Contributor
|
Thanks for fixing! Could we re-run the failed test at https://app.circleci.com/pipelines/github/facebookincubator/gloo/520/workflows/e701bbf6-cd61-4cdf-a38c-8903f83ef158/jobs/4942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Current code always builds nccl module as long as USE_ROCM is ON.
However, we should build it only when USE_RCCL is ON. This patch fixes
it by adding the hipified nccl files in nccl/CMakeLists.txt which will be included
only when USE_RCCL is ON.
Differential Revision: D35636872