fix hipified source path #331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: At OSS gloo build time, all cu files are hipified by cmake for AMD build. The hipified source files are in cmake build directory which can be different from the original source path. Thus, we should always use HIPIFY_OUTPUT_DIR rather than CMAKE_CURRENT_SOURCE_DIR to include these files. HIPIFY_OUTPUT_DIR is defined by Hipify.cmake. This diff fixes failure captured by OSS pytorch when trying to update gloo commit hash: https://github.com/pytorch/pytorch/runs/6379162434?check_suite_focus=true Particular error: ``` *** No rule to make target '../third_party/gloo/gloo/nccl/nccl.hip', needed by 'third_party/gloo/gloo/CMakeFiles/gloo_hip.dir/nccl/gloo_hip_generated_nccl.hip.o'. Stop. ``` Differential Revision: D36457504 fbshipit-source-id: 557c93c74cc460d0fe343733e3de99c9842449d5
|
This pull request was exported from Phabricator. Differential Revision: D36457504 |
jiayisuse
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
At OSS gloo build time, all cu files are hipified by cmake for AMD build.
The hipified source files are in cmake build directory which can be different
from the original source path. Thus, we should always use HIPIFY_OUTPUT_DIR
rather than CMAKE_CURRENT_SOURCE_DIR to include these files.
HIPIFY_OUTPUT_DIR is defined by Hipify.cmake.
This diff fixes failure captured by OSS pytorch when trying to update gloo commit hash: https://github.com/pytorch/pytorch/runs/6379162434?check_suite_focus=true
Particular error:
Differential Revision: D36457504