[ROCm] Updates to remove HIP deprecated symbols #355
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pruthvistony
commented
Mar 28, 2023
pruthvistony
commented
- Removed usage of HIP_HCC_FLAGS
- Proper of include path for rccl.h
- Removed usage of HIP_HCC_FLAGS - Proper of include path for rccl.h
Contributor
Author
|
The failure isnt related to current change. |
Contributor
Author
|
cc @malfet , |
malfet
approved these changes
Apr 10, 2023
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lisaong
pushed a commit
to lisaong/gloo
that referenced
this pull request
Feb 19, 2024
Summary: - Removed usage of HIP_HCC_FLAGS - Proper of include path for rccl.h Pull Request resolved: pytorch#355 Reviewed By: ezyang Differential Revision: D44859009 Pulled By: malfet fbshipit-source-id: cb476dcafae5110d62697047496abcb742fc381b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.