[Store] Introduce optional append method. #357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fduwjj
reviewed
Apr 26, 2023
Contributor
fduwjj
left a comment
fduwjj
left a comment
There was a problem hiding this comment.
Are existing test plans enough?
Author
Yes, because we're not modifying exiting functionality. The only implementations of the new store API will be in PT, so there isn't much to test here. |
fduwjj
approved these changes
Apr 27, 2023
Contributor
fduwjj
left a comment
fduwjj
left a comment
There was a problem hiding this comment.
Unblock. Does the CI failure matter here?
V2 Store extends with the following methods: append, multi_get and multi_set. Capabiltities can be probed at runtime and compile time.
|
@kumpera has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append is an optional operation for stores.
The semantics is to create or append the value to a given key.
Test plan:
It builds.
This change was tested from PyTorch.