Skip to content

Conversation

@dsciebu
Copy link
Contributor

@dsciebu dsciebu commented Jan 23, 2024

Project does not build with -DUSE_LIBUV=ON , due to the introduction of virtual isConnected() in base Pair class. This patch fixes it.

@facebook-github-bot
Copy link

Hi @dsciebu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix

@dsciebu
Copy link
Contributor Author

dsciebu commented Jan 23, 2024

Thank you for the fix

np

@facebook-github-bot
Copy link

@malfet merged this pull request in 89abe67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants