Skip to content

gloo/tcp: better error message on collective mismatch #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

gloo/tcp: better error message on collective mismatch #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gloo/transport/tcp/pair.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,10 @@ ssize_t Pair::prepareRead(
iov.iov_len = op.preamble.length - offset;

// Bytes read must be in bounds for target buffer
GLOO_ENFORCE_LE(op.preamble.length, op.nbytes);
GLOO_ENFORCE_LE(
op.preamble.length,
op.nbytes,
"Received data size doesn't match expected size. Is there a distributed collective mismatch in your code?");
return iov.iov_len;
}

Expand Down
Loading