Skip to content

[ROCm] Support building PyTorch with GLOO on Windows #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

[ROCm] Support building PyTorch with GLOO on Windows #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions cmake/Dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,17 @@ if(USE_ROCM)
include(cmake/Hip.cmake)
if(HAVE_HIP)
include(cmake/Hipify.cmake)
list(APPEND HIP_CXX_FLAGS -fPIC)
list(APPEND HIP_CXX_FLAGS -D__HIP_PLATFORM_HCC__=1)
list(APPEND HIP_CXX_FLAGS -DCUDA_HAS_FP16=1)
list(APPEND HIP_CXX_FLAGS -D__HIP_NO_HALF_OPERATORS__=1)
list(APPEND HIP_CXX_FLAGS -D__HIP_NO_HALF_CONVERSIONS__=1)
list(APPEND HIP_CXX_FLAGS -DHIP_VERSION=${HIP_VERSION_MAJOR})
list(APPEND HIP_CXX_FLAGS -Wno-shift-count-negative)
list(APPEND HIP_CXX_FLAGS -Wno-shift-count-overflow)
list(APPEND HIP_CXX_FLAGS -Wno-duplicate-decl-specifier)
if(NOT WIN32)
list(APPEND HIP_CXX_FLAGS -fPIC)
list(APPEND HIP_CXX_FLAGS -Wno-shift-count-negative)
list(APPEND HIP_CXX_FLAGS -Wno-shift-count-overflow)
list(APPEND HIP_CXX_FLAGS -Wno-duplicate-decl-specifier)
endif()
list(APPEND HIP_CXX_FLAGS -DUSE_MIOPEN)

set(HIP_CLANG_FLAGS ${HIP_CXX_FLAGS})
Expand Down
4 changes: 3 additions & 1 deletion cmake/Hipify.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ endfunction(prepend)
set(HIPIFY_SCRIPTS_DIR ${PROJECT_SOURCE_DIR}/tools/amd_build)
file(GLOB HIPIFY_SCRIPTS ${HIPIFY_SCRIPTS_DIR}/*.py)
set(HIPIFY_OUTPUT_ROOT_DIR ${PROJECT_BINARY_DIR}/hip)

find_package (Python3 COMPONENTS Interpreter)
set(HIPIFY_COMMAND
${HIPIFY_SCRIPTS_DIR}/build_amd.py
${Python3_EXECUTABLE} ${HIPIFY_SCRIPTS_DIR}/build_amd.py
--project-directory ${PROJECT_SOURCE_DIR}
--output-directory ${HIPIFY_OUTPUT_ROOT_DIR}
)
Expand Down
Loading