Skip to content

Conversation

@jackbondpreston-arm
Copy link
Contributor

.gitmodules still contains the googletest module. This was added in 1bf61b8 and 0f7b7b2. The third-party/googletest module link was removed in d7bc190, but .gitmodules was not updated to remove it.

This commit removes .gitmodules, as the googletest module is no longer used, and no other modules are defined in the file.

.gitmodules still contains the googletest module. This was added
in 1bf61b8 and
0f7b7b2. The third-party/googletest
module link was removed in d7bc190, but
.gitmodules was not updated to remove it.

This commit removes .gitmodules, as the googletest module is no longer
used, and no other modules are defined in the file.
@meta-cla meta-cla bot added the CLA Signed label Oct 14, 2025
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass

@meta-codesync
Copy link

meta-codesync bot commented Oct 20, 2025

@d4l3k has imported this pull request. If you are a Meta employee, you can view this in D85094072.

@meta-codesync meta-codesync bot merged commit 0e2f566 into pytorch:main Oct 21, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants