This repository was archived by the owner on Jul 1, 2025. It is now read-only.
Ignore rest of outputs of LayerNorm when lowering to Glow #4343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D20627768 |
Summary: Pull Request resolved: pytorch/pytorch#35338 Pull Request resolved: pytorch#4343 - Ignore rest of outputs of layoutNorm - Support implicit broadcast when loading basic binary ops from Glow. Reviewed By: jfix71 Differential Revision: D20627768 fbshipit-source-id: beaca0b22ce65e32fbda96780c271f2cff2e4d8e
yinghai
force-pushed
the
export-D20627768
branch
from
2fec63d to
e1b3937
Compare
|
This pull request was exported from Phabricator. Differential Revision: D20627768 |
yinghai
pushed a commit
to yinghai/pytorch
that referenced
this pull request
Mar 25, 2020
) Summary: Pull Request resolved: pytorch#35338 Pull Request resolved: pytorch/glow#4343 - Ignore rest of outputs of layoutNorm - Support implicit broadcast when loading basic binary ops from Glow. Test Plan: ``` buck test glow/fb/test:test_onnxifinnpi -- test_layernorm_mul --print-passing-details ``` Reviewed By: jfix71 Differential Revision: D20627768 fbshipit-source-id: 4d13cd47e95afd97118735e138d3529f62daf5a4
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 25, 2020
Summary: Pull Request resolved: #35338 Pull Request resolved: pytorch/glow#4343 - Ignore rest of outputs of layoutNorm - Support implicit broadcast when loading basic binary ops from Glow. Test Plan: ``` buck test glow/fb/test:test_onnxifinnpi -- test_layernorm_mul --print-passing-details ``` Reviewed By: jfix71 Differential Revision: D20627768 fbshipit-source-id: 30ae8a2f590452f0b354d413ae2c5ec46a4a77d8
|
This pull request has been merged in 3aff53b. |
vdantu
pushed a commit
to vdantu/glow
that referenced
this pull request
Jul 12, 2020
Summary: Pull Request resolved: pytorch/pytorch#35338 Pull Request resolved: pytorch#4343 - Ignore rest of outputs of layoutNorm - Support implicit broadcast when loading basic binary ops from Glow. Reviewed By: jfix71 Differential Revision: D20627768 fbshipit-source-id: 30ae8a2f590452f0b354d413ae2c5ec46a4a77d8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D20627768