This repository was archived by the owner on Jul 1, 2025. It is now read-only.
Move fakelowp tests from glow to caffe2 #4409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Since glow OSS doesn't really ship with python, it's much easier to do it in pytorch. All the glow dependency can be done though LD_LIBRARY_PATH in OSS. Reviewed By: amylittleyang Differential Revision: D20969308 fbshipit-source-id: ca5c7e8db6fb7c06c6fe1fcecdc2dcd7fd21f298
|
This pull request was exported from Phabricator. Differential Revision: D20969308 |
yinghai
pushed a commit
to yinghai/pytorch
that referenced
this pull request
Apr 10, 2020
Summary: Pull Request resolved: pytorch/glow#4409 Since glow OSS doesn't really ship with python, it's much easier to do it in pytorch. All the glow dependency can be done though LD_LIBRARY_PATH in OSS. Test Plan: ``` buck test caffe2/caffe2/python/fakelowp: ``` Reviewed By: amylittleyang Differential Revision: D20969308 fbshipit-source-id: 8ec5d71484f49bf60110ed9735bc1df596e6737e
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 10, 2020
Summary: Pull Request resolved: #36409 Pull Request resolved: pytorch/glow#4409 Since glow OSS doesn't really ship with python, it's much easier to do it in pytorch. All the glow dependency can be done though LD_LIBRARY_PATH in OSS. Test Plan: ``` buck test caffe2/caffe2/python/fakelowp: ``` Reviewed By: amylittleyang Differential Revision: D20969308 fbshipit-source-id: 06a02d23f4972a92beb18e1d052e27d8724539d0
|
This pull request has been merged in 35e9c88. |
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Apr 13, 2020
Summary: Pull Request resolved: pytorch#36409 Pull Request resolved: pytorch/glow#4409 Since glow OSS doesn't really ship with python, it's much easier to do it in pytorch. All the glow dependency can be done though LD_LIBRARY_PATH in OSS. Test Plan: ``` buck test caffe2/caffe2/python/fakelowp: ``` Reviewed By: amylittleyang Differential Revision: D20969308 fbshipit-source-id: 06a02d23f4972a92beb18e1d052e27d8724539d0
vdantu
pushed a commit
to vdantu/glow
that referenced
this pull request
Jul 12, 2020
Summary: Pull Request resolved: pytorch/pytorch#36409 Pull Request resolved: pytorch#4409 Since glow OSS doesn't really ship with python, it's much easier to do it in pytorch. All the glow dependency can be done though LD_LIBRARY_PATH in OSS. Reviewed By: amylittleyang Differential Revision: D20969308 fbshipit-source-id: 06a02d23f4972a92beb18e1d052e27d8724539d0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Since glow OSS doesn't really ship with python, it's much easier to do it in pytorch. All the glow dependency can be done though LD_LIBRARY_PATH in OSS.
Reviewed By: amylittleyang
Differential Revision: D20969308