Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

Conversation

omromano
Copy link
Contributor

Summary:
Update of NNPI Backend to v0.5.2.5.

@facebook-github-bot
Copy link

Hi @omromano!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@omromano
Copy link
Contributor Author

@jfix71 @arunm-git Please take a look.

Thanks
CC: @jsubag

Copy link
Contributor

@jfix71 jfix71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hl475 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request May 15, 2020
Summary:
Update of NNPI Backend to v0.5.2.5.
Pull Request resolved: pytorch/glow#4464

Reviewed By: arunm-git

Differential Revision: D21418023

Pulled By: hl475

fbshipit-source-id: 254fcbca28bce0cfc37672306db7f9a352423d18
@facebook-github-bot
Copy link

@hl475 merged this pull request in 0d8034b.

@hl475
Copy link
Contributor

hl475 commented May 15, 2020

Thanks @omromano for the PR! This PR has been landed into Facebook internal with some additional change:

  1. NNPIHostManagerTest.cpp: We blacked list testStaticAssignmentP2PandDRTConcurrent/0, testStaticAssignmentDeviceResidentTensorOnly/0, testStaticAssignmentP2PandDRT/0, testStaticAssignmentP2POnly/0, testSaturateHost/0, ConcurrentAddRemoveUnique/0, whereas the original PR has only ConcurrentAddRemoveUnique/0 in the blacked list. These tests are causing hang during our test NNPIHostManagerTest.cpp.
  2. We revert the change in importer.cpp. The change in importer.cpp passes NNPI/OperatorStatelessTest.rowwiseQuantizedFCTestSymmetric/0 test on our B0 hosts, but fail on A0 hosts.

If you can please help us take a look so we can fix it in the next release, that would be really appreciated.

cc @arunm-git

@omromano
Copy link
Contributor Author

Thanks @hl475, we will address these issue in the next PR.

vdantu pushed a commit to vdantu/glow that referenced this pull request Jul 12, 2020
Summary:
Update of NNPI Backend to v0.5.2.5.
Pull Request resolved: pytorch#4464

Reviewed By: arunm-git

Differential Revision: D21418023

Pulled By: hl475

fbshipit-source-id: 254fcbca28bce0cfc37672306db7f9a352423d18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants