This repository was archived by the owner on Jul 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 699
Update to NNP-I v1.0.0.5 #4770
Closed
Closed
Update to NNP-I v1.0.0.5 #4770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @jfix71, @arunm-git, |
jfix71
reviewed
Aug 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @omromano -- some tiny nits, but LGTM otherwise.
Thanks @jfix71, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hl475 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jfix71
approved these changes
Aug 4, 2020
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 12, 2020
Summary: Align code to NNP-I v1.0.0.5 (glow tracing changes). Pull Request resolved: pytorch/glow#4770 Reviewed By: arunm-git Differential Revision: D22927904 Pulled By: hl475 fbshipit-source-id: 3746a6b07f3fcffc662d80a95513427cfccac7a5
geoffberry
pushed a commit
to geoffberry/glow
that referenced
this pull request
Nov 8, 2020
Summary: Align code to NNP-I v1.0.0.5 (glow tracing changes). Pull Request resolved: pytorch#4770 Reviewed By: arunm-git Differential Revision: D22927904 Pulled By: hl475 fbshipit-source-id: 3746a6b07f3fcffc662d80a95513427cfccac7a5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Align code to NNP-I v1.0.0.5 (glow tracing changes).