This repository was archived by the owner on Jul 1, 2025. It is now read-only.
Add support for constants to fx_glow #5329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D26375577 |
gcatron
added a commit
to gcatron/glow
that referenced
this pull request
Feb 11, 2021
Summary: Pull Request resolved: pytorch/pytorch#52094 Pull Request resolved: pytorch#5329 Nested constants are created as placeholders by the graph_splitter used in the partitioner. So we change them back to get_attr nodes before serializing the graph. Differential Revision: D26375577 fbshipit-source-id: 20aabe514847d6f46120f8ea8b0f9fea014a0121
gcatron
force-pushed
the
export-D26375577
branch
from
3b5b572 to
ea539f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D26375577 |
Summary: Pull Request resolved: pytorch/pytorch#52094 Pull Request resolved: pytorch#5329 Nested constants are created as placeholders by the graph_splitter used in the partitioner. So we change them back to get_attr nodes before serializing the graph. Reviewed By: jfix71 Differential Revision: D26375577 fbshipit-source-id: b53f26e58778e5427b8ecea841f71c2518f545e9
|
This pull request was exported from Phabricator. Differential Revision: D26375577 |
gcatron
force-pushed
the
export-D26375577
branch
from
ea539f1 to
6730d5f
Compare
gcatron
added a commit
to gcatron/pytorch
that referenced
this pull request
Feb 11, 2021
Summary: Pull Request resolved: pytorch#52094 Pull Request resolved: pytorch/glow#5329 Nested constants are created as placeholders by the graph_splitter used in the partitioner. So we change them back to get_attr nodes before serializing the graph. Reviewed By: jfix71 Differential Revision: D26375577 fbshipit-source-id: 72e41530eff02cfc0300e37549ded22668d1628d
|
This pull request has been merged in 64d8af0. |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 11, 2021
Summary: Pull Request resolved: #52094 Pull Request resolved: pytorch/glow#5329 Nested constants are created as placeholders by the graph_splitter used in the partitioner. So we change them back to get_attr nodes before serializing the graph. Reviewed By: jfix71 Differential Revision: D26375577 fbshipit-source-id: 66631aadd6f5b8826ffa0a1e70176fbcaa7431d5
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#52094 Pull Request resolved: pytorch/glow#5329 Nested constants are created as placeholders by the graph_splitter used in the partitioner. So we change them back to get_attr nodes before serializing the graph. Reviewed By: jfix71 Differential Revision: D26375577 fbshipit-source-id: 66631aadd6f5b8826ffa0a1e70176fbcaa7431d5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Nested constants are created as placeholders by the graph_splitter used in the partitioner. So we change them back to get_attr nodes before serializing the graph.
Differential Revision: D26375577