Skip to content

Ignore passed in config when force autotune is turned on #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

Ignore passed in config when force autotune is turned on #1060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions helion/runtime/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,9 @@ def _implicit_config(self) -> Config | None:
configs = self.kernel.configs
if self._config is not None:
return self._config
if self.settings.force_autotune:
# If force autotune is enabled, do not pick an implicit config
return None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious should we move this before if self._config is not None: above?

Copy link
Contributor Author

@oulgen oulgen Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self._config set means we already autotuned in this process, so i was thinking we shouldnt autotune twice in the same process

if len(configs) == 1:
return configs[0]
if len(configs) == 0 and self.kernel.settings.autotune_effort == "none":
Expand Down
Loading