-
Notifications
You must be signed in to change notification settings - Fork 75
Use pyrefly for type checking #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
oulgen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also update agents.md
|
|
||
| - repo: https://github.com/RobertCraigie/pyright-python | ||
| rev: v1.1.407 | ||
| - repo: https://github.com/facebook/pyrefly-pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the pyrefly with the version in the config? i think @lolpack added something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried switching to the second option here that's supposed to let you specify the version, but I couldn't get it to work. Pyrefly starts producing a lot of import errors (on torch, triton, etc.) that suggest it's no longer able to find dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened an issue against pyrefly-pre-commit: facebook/pyrefly-pre-commit#7.
Update references to pyright and pyre, respectively.
|
Woohoo! @oulgen thanks for the speedy review |
This PR switches the type checker for helion from pyright to pyrefly. Benefits of switching:
# pyright: ignoredirectives; only 340# pyrefly: ignoredirectives are needed.The bulk of this PR is a mechanical removal of pyright suppressions and addition of pyrefly suppressions. The interesting changes are:
typing.castcalls that are no longer needed.