Skip to content

Fixes #833 #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2020
Merged

Fixes #833 #1001

merged 3 commits into from
May 1, 2020

Conversation

@vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Apr 30, 2020 •
edited
Loading

Fixes #833

Description:

  • Added set_data method to Engine
  • added a missing test to tests/ignite/engine/test_deterministic.py

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

cc @WeirdKeksButtonK

@vfdev-5
Fixes pytorch#833
396fb2b 
- Added set_data method to Engine
- added a missing test to tests/ignite/engine/test_deterministic.py
@vfdev-5 vfdev-5 requested a review from sdesrozis April 30, 2020 21:26
sdesrozis
sdesrozis approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vfdev-5 vfdev-5 merged commit fb63728 into pytorch:master May 1, 2020
@vfdev-5 vfdev-5 deleted the issue-833 branch May 1, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sdesrozis sdesrozis sdesrozis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to set a new dataloader during training?

2 participants

@vfdev-5 @sdesrozis