ci: run linkcheck only on push and pull

[ydcjeff]

fix: #2066

Description: Run linkcheck job only on push and pull events

Check list:

• New tests are added (if a new feature is added)
• New doc strings: description and/or example code are in RST format
• Documentation is updated (if required)

[trsvchn]

Thanks @ydcjeff !

But I think it still will be triggered only for master push events, and all branches pull_request events right?

[ydcjeff]

Thanks @ydcjeff !

But I think it still will be triggered only for master push events, and all branches pull_request events right?

Yes, we can edit branch for push events

[trsvchn]

we need smth like this, in pseudo code:

on:
  push:
    branches: all
  pull_request:
    branches: all
  release:
    types: [published]

jobs:
  build-deploy:
    if:  (branch == master AND github.event_name == 'push')) OR (gh.event == release)
...
  linkcheck:
    if: github.event_name == 'pull_request' || github.event_name == 'push'

[ydcjeff]

Assuming we are doing push, pull, and release, current workflow file is doing the same as the pseudo code.

[trsvchn]

Current workflow looks like this:

on:
  push:
    branches: all
  pull_request:
    branches: all
  release:
    types: [published]

jobs:
  build-deploy:
    if:  (branch == master AND github.event_name == 'push') OR (gh.event == release)
...
  linkcheck:
    if: github.event_name == 'pull_request' OR (github.event_name == 'push' AND (branch == master)) OR gh.event == release

[ydcjeff]

Sorry, I mean this PR workflow file

[trsvchn]

Let's call it "proposed" :)

Proposed workflow looks like this:

on:
  push:
    branches: all
  pull_request:
    branches: all
  release:
    types: [published]

jobs:
  build-deploy:
    if:  (branch == master AND github.event_name == 'push') OR (gh.event == release)
...
  linkcheck:
    if: github.event_name == 'pull_request' OR (github.event_name == 'push' AND (branch == master))

[trsvchn]

LGTM! Thanks @ydcjeff !