Skip to content

Conversation

JeevanChevula
Copy link
Contributor

Adds a new method has_registered_events(event) -> bool to the Engine class to check whether a specific event is registered with the engine.

This method will be used by the Checkpoint handler to determine if custom events need to be registered, improving separation of concerns between Engine and Checkpoint classes.

Related to PR #3440 (checkpoint events feature)

@github-actions github-actions bot added the module: engine Engine module label Sep 9, 2025
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR @JeevanChevula
Please also write tests with built-in events in test_engine.py and custom events in test_custom_events.py

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JeevanChevula !
Let's see if the CI is passing (we can have some unrelated failure on the CI)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 10, 2025

@JeevanChevula can you please code styling issue: https://github.com/pytorch/ignite/actions/runs/17579433225/job/49932341505?pr=3449

@JeevanChevula
Copy link
Contributor Author

Fixed formatting issues

@vfdev-5 vfdev-5 enabled auto-merge September 11, 2025 08:59
@JeevanChevula
Copy link
Contributor Author

I investigated the CI failures and found the error message 'Please remove this workaround and restore dataset check.' appearing in all failed runs. I'm unsure of the exact cause, but I believe this may be an error independent of the PR functionality, as it appears to be related to Caltech101 dataset handling rather than the Engine method implementation

@vfdev-5 vfdev-5 disabled auto-merge September 11, 2025 12:24
@vfdev-5 vfdev-5 merged commit 8caf979 into pytorch:master Sep 11, 2025
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: engine Engine module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants