-
-
Notifications
You must be signed in to change notification settings - Fork 657
Add has_registered_events method to Engine class #3449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add has_registered_events method to Engine class #3449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick PR @JeevanChevula
Please also write tests with built-in events in test_engine.py and custom events in test_custom_events.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @JeevanChevula !
Let's see if the CI is passing (we can have some unrelated failure on the CI)
@JeevanChevula can you please code styling issue: https://github.com/pytorch/ignite/actions/runs/17579433225/job/49932341505?pr=3449 |
…/jeevanchevula/ignite into add-engine-has-registered-events
Fixed formatting issues |
I investigated the CI failures and found the error message 'Please remove this workaround and restore dataset check.' appearing in all failed runs. I'm unsure of the exact cause, but I believe this may be an error independent of the PR functionality, as it appears to be related to Caltech101 dataset handling rather than the Engine method implementation |
Adds a new method
has_registered_events(event) -> bool
to the Engine class to check whether a specific event is registered with the engine.This method will be used by the Checkpoint handler to determine if custom events need to be registered, improving separation of concerns between Engine and Checkpoint classes.
Related to PR #3440 (checkpoint events feature)