Skip to content

Fix failing distributed sampler test #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2025
Merged

Fix failing distributed sampler test #3453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f823e5
Fix failing distributed sampler test
vfdev-5 Sep 25, 2025
1bb3e75
Updated pytorch docker image in gpu GHA workflows
vfdev-5 Sep 25, 2025
130261d
Fix pyOpenSSL version in pth docker image
vfdev-5 Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/gpu-hvd-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
pytorch-channel: [pytorch]
fail-fast: false
env:
DOCKER_IMAGE: "pytorch/conda-builder:cuda12.1"
DOCKER_IMAGE: "pytorch/almalinux-builder:cuda12.8"
REPOSITORY: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number }}
runs-on: linux.8xlarge.nvidia.gpu
Expand Down Expand Up @@ -113,6 +113,10 @@ jobs:
pip install -r requirements-dev.txt
pip install -e .

# Upgrade pyOpenSSL to avoid issue:
# AttributeError: module 'lib' has no attribute 'X509_V_FLAG_NOTIFY_POLICY'. Did you mean: 'X509_V_FLAG_EXPLICIT_POLICY'?
pip install -U pyOpenSSL

EOF
)

Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/gpu-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
pytorch-channel: [pytorch, pytorch-nightly]
fail-fast: false
env:
DOCKER_IMAGE: "pytorch/almalinux-builder:cuda12.4"
DOCKER_IMAGE: "pytorch/almalinux-builder:cuda12.8"
REPOSITORY: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number }}
runs-on: linux.g4dn.12xlarge.nvidia.gpu
Expand Down Expand Up @@ -113,6 +113,10 @@ jobs:
pip install -r requirements-dev.txt
pip install -e .

# Upgrade pyOpenSSL to avoid issue:
# AttributeError: module 'lib' has no attribute 'X509_V_FLAG_NOTIFY_POLICY'. Did you mean: 'X509_V_FLAG_EXPLICIT_POLICY'?
pip install -U pyOpenSSL

EOF
)

Expand Down
2 changes: 1 addition & 1 deletion tests/ignite/distributed/test_auto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def test_dist_proxy_sampler():
DistributedProxySampler(None)

with pytest.raises(TypeError, match=r"Argument sampler should have length"):
DistributedProxySampler(Sampler([1]))
DistributedProxySampler(Sampler())

with pytest.raises(TypeError, match=r"Argument sampler must not be a distributed sampler already"):
DistributedProxySampler(DistributedSampler(sampler, num_replicas=num_replicas, rank=0))
Loading