Skip to content

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Oct 14, 2025

Description:

  • Fixed iteration visual value in fbresearch_logger

Before this PR (10 -> 9 -> 8 -> 7 but should be always 10):

Training: start epoch [1/15]                                                                                                                                                                       
Epoch [1/15]  [10/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Epoch [1/15]  [20/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s  
Training: Epoch [1/15]  Total time: 0:00:00  (0.0000 s / it)                                                                                                                                       
Training: start epoch [2/15]                                                                                                                                                                       
Epoch [2/15]  [9/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                    
Epoch [2/15]  [19/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s  
Training: Epoch [2/15]  Total time: 0:00:00  (0.0000 s / it)                                                                                                                                       
Training: start epoch [3/15]                                                                                                                                                                       
Epoch [3/15]  [8/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                    
Epoch [3/15]  [18/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s  
Training: Epoch [3/15]  Total time: 0:00:00  (0.0000 s / it)                                                                                                                                       
Training: start epoch [4/15]                                                                                                                                                                       
Epoch [4/15]  [7/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                    
Epoch [4/15]  [17/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s  
Training: Epoch [4/15]  Total time: 0:00:00  (0.0000 s / it)                                                                                                                                       
Training: start epoch [5/15]                                                                                                                                                                       
Epoch [5/15]  [6/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                    
Epoch [5/15]  [16/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s 

with the PR:

Training: start epoch [1/15]                                                                                                                                                                       
Epoch [1/15]  [10/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Epoch [1/15]  [20/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Training: Epoch [1/15]  Total time: 0:00:00  (0.0000 s / it)                                                                                                                                       
Training: start epoch [2/15]                                                                                                                                                                       
Epoch [2/15]  [10/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Epoch [2/15]  [20/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Training: Epoch [2/15]  Total time: 0:00:00  (0.0000 s / it)                                                                                                                                       
Training: start epoch [3/15]                                                                                                                                                                       
Epoch [3/15]  [10/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Epoch [3/15]  [20/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Training: Epoch [3/15]  Total time: 0:00:00  (0.0000 s / it)                                                                                                                                       
Training: start epoch [4/15]                                                                                                                                                                       
Epoch [4/15]  [10/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Epoch [4/15]  [20/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Training: Epoch [4/15]  Total time: 0:00:00  (0.0000 s / it)                                                                                                                                       
Training: start epoch [5/15]                                                                                                                                                                       
Epoch [5/15]  [10/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s                                                                                                   
Epoch [5/15]  [20/20]:  ETA: 0:00:00    42.0000    Iter time: 0.0000 s  Data prep time: 0.0000 s  

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label Oct 14, 2025
@vfdev-5 vfdev-5 marked this pull request as ready for review October 14, 2025 12:22
@vfdev-5 vfdev-5 merged commit 0947191 into master Oct 14, 2025
28 of 29 checks passed
@vfdev-5 vfdev-5 deleted the fix-fblogger-iter-value branch October 14, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: handlers Core Handlers module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant