- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 657
 
Add NeptuneLogger #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NeptuneLogger #730
Conversation
… added initial tests file
| 
           @jakubczakon thanks a lot for the PR. Looks good! A question on the link provided in the docs: on your site. About   | 
    
| 
           I fixed that @vfdev-5 .  | 
    
| 
           Thanks for pointing that out @vfdev-5 . I initially started with  On a second thought, I can talk to the team and see if adding this is actually a problem for them.  | 
    
| 
           @jakubczakon I see. Yes, a similar situation is with MLflow for example. A solution can be to log during the training to a temp folder and after the training to send best n model to the server... 
 I would suggest to use directly   | 
    
          
 I will talk to our folks and come back on that as it is a cleaner solution I think. Side note  | 
    
| 
           To merge this PR, I propose to remove for instance   | 
    
| 
           It is possible that this   | 
    
| 
           @jakubczakon perfect! We can wait until the feedback from your side and do as you proposed.  | 
    
| 
           Ok, I spoke to my team and we should have that in the next few days but I am not sure on the ETA and I think it is a better idea to drop   | 
    
| 
           @jakubczakon sounds good, let's do it like that !  | 
    
| 
           @jakubczakon yes, I see. Could you please, just drop   | 
    
| 
           Sorry @vfdev-5 forgot that. It's on the way.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @jakubczakon thanks!
| 
           Perfect, thank you @vfdev-5!  | 
    
Description:
Check list: