- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 657
 
black formatted codebase with pre-commit files #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Thanks @anmolsjoshi ! Huge PR with 164 updated files, if CI passes it is OK for me.  | 
    
| 
           I just got one small question: can't we use black also as a linter? This way it would be more concise than to format with black and to lint with flake and additional exceptions.  | 
    
          
 love this!  | 
    
| 
           @justusschock black is primarily a code formatter. We can invoke it with a --check flag to check if all the files in the code base comply with, but it doesn't suggest what should be changed like flake8. Please see below. black . --check
would reformat /home/joshi/ignite/tests/ignite/metrics/test_metric.py
would reformat /home/joshi/ignite/tests/ignite/metrics/test_accuracy.py
would reformat /home/joshi/ignite/tests/ignite/metrics/test_precision.py
would reformat /home/joshi/ignite/tests/ignite/metrics/test_recall.py
Oh no! 💥 💔 💥
165 files would be reformatted, 19 files would be left unchanged. | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot @anmolsjoshi !
Fixes #
Description:
Per discussion on slack, added black formatting to codebase.
Helpful links:
Check list: