Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libkineto/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ target_include_directories(kineto_base PUBLIC
$<BUILD_INTERFACE:${CUDA_INCLUDE_DIRS}>)

target_include_directories(kineto_api PUBLIC
$<BUILD_INTERFACE:${FMT_INCLUDE_DIR}>
$<BUILD_INTERFACE:${LIBKINETO_INCLUDE_DIR}>)

if(KINETO_LIBRARY_TYPE STREQUAL "default")
Expand Down
15 changes: 15 additions & 0 deletions libkineto/include/ClientTraceActivity.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@

#pragma once

#include <fmt/format.h>
#include <string>
#include <thread>
#include <vector>

#include "TraceActivity.h"

Expand Down Expand Up @@ -56,6 +58,16 @@ struct ClientTraceActivity : TraceActivity {
// Unimplemented by default
}

// Encode client side metadata as a key/value string.
void addMetadata(const std::string& key, const std::string& value) {
auto kv = fmt::format("\"{}\": {}", key, value);
metadata_.push_back(std::move(kv));
}

[[nodiscard]] const std::string getMetadata() const {
return fmt::format("{}", fmt::join(metadata_, ", "));
}

int64_t startTime{0};
int64_t endTime{0};
int64_t correlation{0};
Expand All @@ -72,6 +84,9 @@ struct ClientTraceActivity : TraceActivity {
std::string inputNames;
std::string outputNames;
std::string callStack;

private:
std::vector<std::string> metadata_;
};

} // namespace libkineto
1 change: 1 addition & 0 deletions libkineto/libkineto_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def get_libkineto_public_headers():
return [
"include/ActivityProfilerInterface.h",
"include/ActivityType.h",
"include/ClientTraceActivity.h",
"include/ClientInterface.h",
"include/TraceActivity.h",
"include/TraceSpan.h",
Expand Down