Skip to content

fix security warning like X-Content-Type-Options is required to be no… #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2021
Merged

fix security warning like X-Content-Type-Options is required to be no… #166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5079d0
fix security warning like X-Content-Type-Options is required to be no…
guotuofeng Apr 14, 2021
c6ce03c
Merge branch 'plugin/0.2' into myguo/warn
guotuofeng Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tb_plugin/torch_tb_profiler/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class TorchProfilerPlugin(base_plugin.TBPlugin):
"""TensorBoard plugin for Torch Profiler."""

plugin_name = consts.PLUGIN_NAME
headers = [('X-Content-Type-Options', 'nosniff')]

def __init__(self, context):
"""Instantiates TorchProfilerPlugin.
Expand Down Expand Up @@ -252,9 +253,10 @@ def trace_route(self, request):
if profile.trace_file_path.endswith('.gz'):
headers = []
headers.append(('Content-Encoding', 'gzip'))
headers.extend(TorchProfilerPlugin.headers)
return werkzeug.Response(raw_data, content_type="application/json", headers=headers)
else:
return werkzeug.Response(raw_data, content_type="application/json")
return werkzeug.Response(raw_data, content_type="application/json", headers=TorchProfilerPlugin.headers)

@wrappers.Request.application
def static_file_route(self, request):
Expand All @@ -273,15 +275,15 @@ def static_file_route(self, request):
with open(filepath, 'rb') as infile:
contents = infile.read()
except IOError:
return werkzeug.Response('404 Not Found', 'text/plain', code=404)
return werkzeug.Response('404 Not Found', 'text/plain', code=404, headers=TorchProfilerPlugin.headers)
return werkzeug.Response(
contents, content_type=mimetype
contents, content_type=mimetype, headers=TorchProfilerPlugin.headers
)

@staticmethod
def respond_as_json(obj):
content = json.dumps(obj)
return werkzeug.Response(content, content_type="application/json")
return werkzeug.Response(content, content_type="application/json", headers=TorchProfilerPlugin.headers)


def _load_run(queue, name, run_dir):
Expand Down