Skip to content

Conversation

@licj15
Copy link

@licj15 licj15 commented May 5, 2021

on_trace_ready should be the the arg of torch.profiler.profile instead of torch.profiler.schedule.

@facebook-github-bot
Copy link
Contributor

Hi @licj15!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@nbcsm
Copy link
Contributor

nbcsm commented May 5, 2021

@licj15, thanks for the contribution!
Could you sign the Facebook CLA please? So we can accept the PR.

@nbcsm nbcsm added documentation Improvements or additions to documentation plugin PyTorch Profiler TensorBoard Plugin related labels May 5, 2021
@licj15
Copy link
Author

licj15 commented May 5, 2021

@licj15, thanks for the contribution!
Could you sign the Facebook CLA please? So we can accept the PR.

@nbcsm I signed the CLA just now. Thank you for your notification!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@nbcsm nbcsm requested a review from gdankel May 5, 2021 12:10
@guotuofeng guotuofeng changed the base branch from master to plugin/0.2 June 18, 2021 06:22
@guotuofeng guotuofeng closed this Jun 18, 2021
@guotuofeng guotuofeng mentioned this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed documentation Improvements or additions to documentation plugin PyTorch Profiler TensorBoard Plugin related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants